Define dropdown menu background in foundation-dropdown-menu mixin #11377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncoden
approved these changes
Jul 3, 2018
There was a problem hiding this comment.
LGTM, thank you @rlhawk 💯
For reference:
$dropdownmenu-backgroundwas added in 658ed64 to set the submenu backgrounds$dropdownmenu-submenu-backgroundwas added in 902a485 but not used.$dropdownmenu-submenu-backgroundwas used for the submenu backgrounds instead of$dropdownmenu-backgroundin eb6b0fb, and$dropdownmenu-backgroundwas not used anymore.
DanielRuf
approved these changes
Jul 3, 2018
ncoden
added a commit
that referenced
this pull request
Jul 4, 2018
Define dropdown menu background in foundation-dropdown-menu mixin
ncoden
pushed a commit
to ncoden/foundation-sites
that referenced
this pull request
Jul 6, 2018
0ec2be1 Define dropdown menu background in foundation-dropdown-menu mixin Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
ncoden
pushed a commit
to ncoden/foundation-sites
that referenced
this pull request
Jul 8, 2018
0ec2be1 Define dropdown menu background in foundation-dropdown-menu mixin Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Aug 2, 2018
Changes: - Only apply top-level styles to top-level items. This increase specificity but this markup structure is alreaddy assumed elsewhere in the component. - Remove the default `$white` background on top-level items: it was never applied before foundation#11377 and could now cause visual changes. Closes foundation#11412
This was referenced Aug 2, 2018
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The $dropdownmenu-background variable is used to set the background of a top-level dropdown menu items.
Motivation and Context
This change allows the background to be set for top-level dropdown menu items using a Foundation setting variable that is currently defined, but not used.
Types of changes
functionality to change)
Checklist (all required):
developorsupport/*).