Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add a notice about required CSS in Media Query doc #11382

Merged
merged 2 commits into from
Jul 5, 2018
Merged

docs: add a notice about required CSS in Media Query doc #11382

merged 2 commits into from
Jul 5, 2018

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented Jul 4, 2018

Description

screenshot 2018-07-04 at 22 45 10

Add a message in the Media Query documentation to warn that the MediaQuery helper require @foundation-global-styles() to have been called.

Partially resolve #11374

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or support/*).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • All new and existing tests passed.

@ncoden ncoden requested a review from DanielRuf July 4, 2018 20:48
@ncoden ncoden mentioned this pull request Jul 4, 2018
Closed
4 tasks
@ncoden ncoden added this to the 6.5.0 milestone Jul 4, 2018
DanielRuf
DanielRuf suggested changes Jul 5, 2018
View reviewed changes
docs/pages/media-queries.md Outdated
@@ -187,6 +187,10 @@ This can be used to combine multiple media queries together.

The Foundation JavaScript includes a set of helper functions for working with media queries. They're all on the `Foundation.MediaQuery` object.

<div class="callout warning">
The MediaQuery utility uses the Sass breakpoints settings and require the Foundation CSS to be imported. For Sass users, you need to include either `foundation-everything()` or `foundation-global-styles()`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MediaQuery utility uses the Sass breakpoint settings and requires the Foundation CSS to be imported. For Sass users, you need to include either foundation-everything() or foundation-global-styles()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ncoden
Copy link
Contributor Author

ncoden commented Jul 5, 2018

@DanielRuf I fixed the typo.

@ncoden ncoden merged commit 6c576ff into foundation:develop Jul 5, 2018
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jul 6, 2018
@ncoden
Use pull request foundation#11382 from ncoden/docs/media-query-global…
04f56cd 
…-styles-notice-11374 for v6.5.0

deee056 docs: add a notice about required CSS in Media Query doc
cfcc36b docs: fix typo in Media Query warning about required CSS

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jul 8, 2018
@ncoden
Use pull request foundation#11382 from ncoden/docs/media-query-global…
41d01e5 
…-styles-notice-11374 for v6.5.0

deee056 docs: add a notice about required CSS in Media Query doc
cfcc36b docs: fix typo in Media Query warning about required CSS

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden ncoden mentioned this pull request Jul 8, 2018
Merged
10 tasks
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf DanielRuf approved these changes

Assignees
No one assigned
Labels
📖 documentation Media Query
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

Mention foundation-global-styles in the JavaScript section
2 participants
@ncoden @DanielRuf