Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: S3FIFO wrongly return empty when evict #360

Closed
MrCroxx opened this issue Apr 17, 2024 · 0 comments · Fixed by #400
Closed

bug: S3FIFO wrongly return empty when evict #360

MrCroxx opened this issue Apr 17, 2024 · 0 comments · Fixed by #400
Assignees
@MrCroxx
Labels
bug Something isn't working
Milestone
v0.8

Comments

@MrCroxx
Copy link
Collaborator

MrCroxx commented Apr 17, 2024 •
edited
Loading

evict may return None even when cache is not empty.

https://github.com/MrCroxx/foyer/blob/main/foyer-memory/src/eviction/s3fifo.rs#L141-L182

If the small queue eviction will be skipped.

https://github.com/MrCroxx/foyer/blob/main/foyer-memory/src/eviction/s3fifo.rs#L161
@MrCroxx MrCroxx added the bug Something isn't working label Apr 17, 2024
@MrCroxx MrCroxx self-assigned this Apr 17, 2024
@MrCroxx MrCroxx mentioned this issue Apr 17, 2024
Closed
@MrCroxx MrCroxx changed the title bug: S3FIFO bug: S3FIFO wrongly evict empty Apr 17, 2024
@MrCroxx MrCroxx changed the title bug: S3FIFO wrongly evict empty bug: S3FIFO wrongly return empty when evict Apr 17, 2024
@MrCroxx MrCroxx added this to the v0.8 milestone Apr 17, 2024
@MrCroxx MrCroxx mentioned this issue Apr 22, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrCroxx MrCroxx

Labels
bug Something isn't working
Projects
foyer - Development Roadmap
Status: No status
Milestone
v0.8
Development

Successfully merging a pull request may close this issue.

feat: add ghost queue for s3fifo, fix panic foyer-rs/foyer
1 participant
@MrCroxx