refactor: refine generic handle type #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
|
After this change, and like you said, we could also remove the indexer. Then, the cache will only have four generic parameters: <K, V, E, S>, which is nice. LGTM |
I personally wish to keep |
Fine.I agree. |
MrCroxx
added a commit
that referenced
this pull request
Apr 17, 2024
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
As title. Remove one generic type from
GenericCacheand related structs.Checklist
make all(ormake fastinstead if the old tests are not modified) in my local environment.Related issues or PRs (optional)
#327