Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assert handle weight and refactor handle #380

Merged
merged 2 commits into from
Apr 20, 2024
Merged

fix: assert handle weight and refactor handle #380

merged 2 commits into from
Apr 20, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Apr 20, 2024

Signed-off-by: MrCroxx mrcroxx@outlook.com## What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title. Also rename charge to weight.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

close #338

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx self-assigned this Apr 20, 2024
@MrCroxx MrCroxx added the bug Something isn't working label Apr 20, 2024
@MrCroxx MrCroxx enabled auto-merge (squash) April 20, 2024 07:16
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 78.10%. Comparing base (cbedab1) to head (cae4c3b).

Files Patch % Lines
foyer-memory/src/cache.rs 0.00% 5 Missing ⚠️
foyer-memory/src/generic.rs 87.50% 2 Missing ⚠️
foyer-memory/src/eviction/lru.rs 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
- Coverage   78.13%   78.10%   -0.04%     
==========================================
  Files          51       51              
  Lines        6412     6402      -10     
==========================================
- Hits         5010     5000      -10     
  Misses       1402     1402              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCroxx MrCroxx merged commit c51d248 into main Apr 20, 2024
13 checks passed
@MrCroxx MrCroxx deleted the xx/handle branch April 20, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

bug: insert value size is zero
1 participant