Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: only restore storage key and value bound if necessary #388

Closed
wants to merge 4 commits into from

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Apr 20, 2024

Signed-off-by: MrCroxx mrcroxx@outlook.com## What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#327

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx self-assigned this Apr 20, 2024
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 98.21429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.86%. Comparing base (23bff43) to head (198bbcd).

❗ Current head 198bbcd differs from pull request most recent head 92aefac. Consider uploading reports for the commit 92aefac to get more accurate results

Files Patch % Lines
foyer-storage/src/generic.rs 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
+ Coverage   77.76%   77.86%   +0.09%     
==========================================
  Files          51       51              
  Lines        6423     6459      +36     
==========================================
+ Hits         4995     5029      +34     
- Misses       1428     1430       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Apr 25, 2024

Outdated.

@MrCroxx MrCroxx closed this Apr 25, 2024
@MrCroxx MrCroxx deleted the xx/kv branch April 25, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant