Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce a-related parameters as natural numbers #48

Merged
merged 6 commits into from
Jul 1, 2024

Conversation

Parcly-Taxel
Copy link
Contributor

@Parcly-Taxel Parcly-Taxel commented Jun 30, 2024

More specifically a, A = 2 ^ A, D = 2 ^ (100 * a ^ 2) and the constant S in the definition of GridStructure.

The blueprint explicitly states that a is natural, and having this avoids "rounding fudges" in some proofs. Cf. Zulip.

Copy link
Owner

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! two comments:

  • Can you revert the changes to DoublingMeasure? A doubling measure is a concept that I would like to move to Mathlib relatively soon, and there is no reason to restrict the parameter to a natural number abstractly.
  • You might want to cast the natural numbers to real numbers as soon as possible, by explicitly writing e.g. (A : ℝ) ^ 2. That might save some exact_mod_casts.

@Parcly-Taxel Parcly-Taxel changed the title Enforce a and A = 2 ^ a to be natural numbers Enforce a-related parameters as natural numbers Jul 1, 2024
@fpvandoorn
Copy link
Owner

Thanks!

@fpvandoorn fpvandoorn merged commit 99645a0 into fpvandoorn:master Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants