Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exit on interrupt #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: exit on interrupt #54

wants to merge 2 commits into from

Conversation

rtdany10
Copy link
Contributor

@rtdany10 rtdany10 commented Oct 13, 2023 •
edited
Loading

The infinite loop and sleep never listened to interrupts or signals causing it to run forever.
Shutting down my laptop took forever as the process wouldn't stop and had to be timed out.

This PR fixes the same.

AvinashReddy3108 added a commit to AvinashReddy3108/biometric-attendance-sync-tool that referenced this pull request Nov 1, 2023
@AvinashReddy3108
touched...
7c9dfa3 
- Realtime sync from device (frappe#55)
- fix: exit on interrupt (frappe#54)
- strip out GUI stuff, remove PyQT5 from dependencies
- formatted code

Co-Authored by: Dany Robert <rtdany10@gmail.com>
AvinashReddy3108 added a commit to AvinashReddy3108/biometric-attendance-sync-tool that referenced this pull request Nov 1, 2023
@AvinashReddy3108 @rtdany10
touched...
aab6c27 
- Realtime sync from device (frappe#55)
- fix: exit on interrupt (frappe#54)
- strip out GUI stuff, remove PyQT5 from dependencies
- formatted code

Co-authored-by: Dany Robert <rtdany10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rtdany10