Skip to content

Commit

Permalink
Merge pull request #37031 from HarryPaulo/fix-auth-rule-based-on
Browse files Browse the repository at this point in the history
fix: "Based on" field always has the value "Not applicable"
  • Loading branch information
deepeshgarg007 authored Sep 13, 2023
2 parents 6664bc9 + fae640c commit 1db05c8
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ def validate_rule(self):
frappe.throw(_("Discount must be less than 100"))
elif self.based_on == "Customerwise Discount" and not self.master_name:
frappe.throw(_("Customer required for 'Customerwise Discount'"))
else:
self.based_on = "Not Applicable"

def validate(self):
self.check_duplicate_entry()
Expand Down

0 comments on commit 1db05c8

Please sign in to comment.