Skip to content

Commit

Permalink
fix(plaid): Do not sync pending transactions
Browse files Browse the repository at this point in the history
(cherry picked from commit 46ea868)
  • Loading branch information
deepeshgarg007 authored and mergify[bot] committed Oct 27, 2023
1 parent f382b1c commit 2149de4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ def allocate_payment_entries(self):
- 0 > a: Error: already over-allocated
- clear means: set the latest transaction date as clearance date
"""
gl_bank_account = frappe.db.get_value("Bank Account", self.bank_account, "account")
remaining_amount = self.unallocated_amount
for payment_entry in self.payment_entries:
if payment_entry.allocated_amount == 0.0:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from frappe import _
from frappe.desk.doctype.tag.tag import add_tag
from frappe.model.document import Document
from frappe.utils import add_months, formatdate, getdate, today
from frappe.utils import add_months, formatdate, getdate, sbool, today
from plaid.errors import ItemError

from erpnext.accounts.doctype.journal_entry.journal_entry import get_default_bank_cash_account
Expand Down Expand Up @@ -237,8 +237,6 @@ def new_bank_transaction(transaction):
deposit = abs(amount)
withdrawal = 0.0

status = "Pending" if transaction["pending"] == True else "Settled"

tags = []
if transaction["category"]:
try:
Expand All @@ -247,13 +245,14 @@ def new_bank_transaction(transaction):
except KeyError:
pass

if not frappe.db.exists("Bank Transaction", dict(transaction_id=transaction["transaction_id"])):
if not frappe.db.exists(
"Bank Transaction", dict(transaction_id=transaction["transaction_id"])
) and not sbool(transaction["pending"]):
try:
new_transaction = frappe.get_doc(
{
"doctype": "Bank Transaction",
"date": getdate(transaction["date"]),
"status": status,
"bank_account": bank_account,
"deposit": deposit,
"withdrawal": withdrawal,
Expand Down

0 comments on commit 2149de4

Please sign in to comment.