fix: added validation for unique serial numbers in pos invoice #36302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
## [13.52.8](v13.52.7...v13.52.8) (2023-08-01) ### Bug Fixes * added validation for unique serial numbers in pos invoice ([#36302](#36302)) ([a165b37](a165b37)) * only publish repost progress to doc subscriber (backport [#36400](#36400)) ([#36403](#36403)) ([e9df064](e9df064)) * removed "fetch_from" (backport [#36365](#36365)) ([#36387](#36387)) ([c574494](c574494)) ### Performance Improvements * use `LEFT JOIN` instead of `NOT EXISTS` (backport [#36221](#36221)) ([#36384](#36384)) ([cdc86bd](cdc86bd))
|
🎉 This PR is included in version 13.52.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
* fix: added validation for unique serial numbers in pos invoice * fix: updated title of validation * fix: removed extra whitespace * fix: added validation for duplicate batch numbers --------- Co-authored-by: Ritvik Sardana <ritviksardana@Ritviks-MacBook-Air.local> (cherry picked from commit a165b37)
deepeshgarg007
pushed a commit
that referenced
this pull request
Sep 5, 2023
fix: added validation for unique serial numbers in pos invoice (#36302) * fix: added validation for unique serial numbers in pos invoice * fix: updated title of validation * fix: removed extra whitespace * fix: added validation for duplicate batch numbers --------- Co-authored-by: Ritvik Sardana <ritviksardana@Ritviks-MacBook-Air.local> (cherry picked from commit a165b37) Co-authored-by: RitvikSardana <65544983+RitvikSardana@users.noreply.github.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
# [14.38.0](v14.37.1...v14.38.0) (2023-09-06) ### Bug Fixes * account payable currency and value ([#36859](#36859)) ([98c2640](98c2640)) * added ignore_user_permissions to parent field of tree doctypes ([451cc7b](451cc7b)) * added validation for unique serial numbers in pos invoice ([#36302](#36302)) ([1192736](1192736)) * allow payment_account of loan repayment to be edited ([#36948](#36948)) ([09e2f24](09e2f24)) * ask for asset related accounts only when needed (backport [#36960](#36960)) ([#36971](#36971)) ([58163d5](58163d5)) * calcuate received/paid amount on rate change in PE ([0a63266](0a63266)) * deduplicate gain/loss JE creation for journals as payment ([9168b3b](9168b3b)) * difference amount in UI should not be calculated ([9bc2b41](9bc2b41)) * fetch discount amount for gle in base currency ([a8b5880](a8b5880)) * ignore mandatory fields while saving WO (backport [#36954](#36954)) ([#36970](#36970)) ([c125dea](c125dea)) * index error on Receivable report based on payment terms ([#36963](#36963)) ([e3d64fc](e3d64fc)) * invalid gain/loss JE created on base currency Expense Claim ([068f1b5](068f1b5)) * only show "Unreconcile" if reconciled ([61752ac](61752ac)) * prorate factor for subscription plan ([#36953](#36953)) ([fc79af5](fc79af5)) * reduce threshold for bg job fn ([5a226a8](5a226a8)) * remove withholding category from common fields ([18f8f7f](18f8f7f)) * Set the default filter in All Trends Report ([132957f](132957f)) * Set the default filter in All Trends Report ([420536c](420536c)) * when create doc from item dashboard default uom (buying or selling) is not correctly selected (backport [#36892](#36892)) ([#36928](#36928)) ([5c8bee0](5c8bee0)) ### Features * **RFQ:** optionally send document print ([#36363](#36363)) ([345c608](345c608))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue :
In the POS Invoicing, it was possible to select the same serial number multiple times.
Reason:
No validation was there to check whether duplicate serial numbers exist or not
Solution:
Added a validation in file POS Invoice
Result:
