-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: AP report does not show expense claim payables #36333
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #36333 +/- ##
===========================================
+ Coverage 64.11% 64.22% +0.11%
===========================================
Files 785 785
Lines 60780 61004 +224
===========================================
+ Hits 38970 39182 +212
- Misses 21810 21822 +12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we can fix this for all party types rather than just for employees, in case any new party type gets introduced
This report accepts some args and party_type is one of them, from my understanding, this is right now to make out if its an accounts receivable or payable report.
The party_type
arg can be replaced with report_type
or account_type
and that can be used to fetch all the party types from the "Party Type" master that have that account type and make other necessary changes in the report
Also similar changes will be needed in Accounts Receivable/Payable summary reports
…-36333 fix: AP report does not show expense claim payables (#36333)
Problem
When an Expense Claim is created using the Expense Claim Doctype from the
hrms
app, the Accounts Payable Report does not fetch the Payment Ledger Entries for the payable expense. This leads to a mismatch between the General Ledger Report balance amount and the Accounts Payable total amount.Accounting Ledger for an Expense Claim of
₹1000
Accounts Payable Report ( Payable for the Expense Claim not recorded ) - Outstanding
₹1000
General Ledger for the Creditors Account - Balance
-₹2000
Solution