Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Comment unusable code and list can not be used as doctype name #37001

Merged
merged 3 commits into from
Sep 13, 2023
Merged

fix: Comment unusable code and list can not be used as doctype name #37001

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5ca5e0
fix: Comment unusable code and list can not be used as doctype name
viralkansodiya Sep 9, 2023
80f7eca
Merge branch 'frappe:develop' into develop
viralkansodiya Sep 11, 2023
314dad7
fix: unusable code is remove
viralkansodiya Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion erpnext/e_commerce/shopping_cart/cart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,7 +631,6 @@ def get_applicable_shipping_rules(party=None, quotation=None):
shipping_rules = get_shipping_rules(quotation)

if shipping_rules:
rule_label_map = frappe.db.get_values("Shipping Rule", shipping_rules, "label")
# we need this in sorted order as per the position of the rule in the settings page
return [[rule, rule] for rule in shipping_rules]

Expand Down
Loading