Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provision to create RIV from Stock Ledger Invariant Check report #37115

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Sep 16, 2023

scrnli_9_17_2023_12-38-46.AM.mp4

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 16, 2023
@s-aga-r s-aga-r force-pushed the RIV-FROM-LEDGER-INVARIANT-CHECK branch from ab9a7d2 to 94694f4 Compare September 16, 2023 19:13
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Sep 16, 2023
@s-aga-r s-aga-r force-pushed the RIV-FROM-LEDGER-INVARIANT-CHECK branch from 94694f4 to 04a3dc7 Compare September 16, 2023 19:17
@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #37115 (deba517) into develop (099468e) will increase coverage by 0.11%.
Report is 17 commits behind head on develop.
The diff coverage is 18.75%.

@@             Coverage Diff             @@
##           develop   #37115      +/-   ##
===========================================
+ Coverage    66.50%   66.61%   +0.11%     
===========================================
  Files          793      793              
  Lines        62435    62517      +82     
===========================================
+ Hits         41520    41648     +128     
+ Misses       20915    20869      -46     
Files Changed Coverage
...er_invariant_check/stock_ledger_invariant_check.py 18.75%

@s-aga-r s-aga-r marked this pull request as ready for review September 19, 2023 07:30
@s-aga-r s-aga-r merged commit 9c9d0ec into frappe:develop Sep 19, 2023
13 checks passed
mergify bot pushed a commit that referenced this pull request Sep 19, 2023
…ort (#37115)

* feat: provision to create RIV from `Stock Ledger Invariant Check` report

* fix: `linter`

(cherry picked from commit 9c9d0ec)
s-aga-r added a commit that referenced this pull request Sep 19, 2023
…ort (backport #37115) (#37147)

feat: provision to create RIV from `Stock Ledger Invariant Check` report (#37115)

* feat: provision to create RIV from `Stock Ledger Invariant Check` report

* fix: `linter`

(cherry picked from commit 9c9d0ec)

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
mergify bot pushed a commit that referenced this pull request Sep 19, 2023
…ort (#37115)

* feat: provision to create RIV from `Stock Ledger Invariant Check` report

* fix: `linter`

(cherry picked from commit 9c9d0ec)

# Conflicts:
#	erpnext/stock/report/stock_ledger_invariant_check/stock_ledger_invariant_check.py
s-aga-r added a commit that referenced this pull request Sep 19, 2023
…ort (backport #37115) (#37149)

* feat: provision to create RIV from `Stock Ledger Invariant Check` report (#37115)

* feat: provision to create RIV from `Stock Ledger Invariant Check` report

* fix: `linter`

(cherry picked from commit 9c9d0ec)

# Conflicts:
#	erpnext/stock/report/stock_ledger_invariant_check/stock_ledger_invariant_check.py

* chore: `conflicts`

---------

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Sep 19, 2023
# [13.53.0](v13.52.15...v13.53.0) (2023-09-19)

### Bug Fixes

* fetch logic for repay_from_salary in loan_repayment [v13] ([#37136](#37136)) ([d4f8b05](d4f8b05))

### Features

* provision to create RIV from `Stock Ledger Invariant Check` report (backport [#37115](#37115)) ([#37149](#37149)) ([86b152f](86b152f))
frappe-pr-bot pushed a commit that referenced this pull request Sep 20, 2023
# [14.40.0](v14.39.0...v14.40.0) (2023-09-20)

### Bug Fixes

* + btn not appearing for delivery note connection (backport [#36980](#36980)) ([#37070](#37070)) ([c2a0c1e](c2a0c1e))
* accepted warehouse and rejected warehouse can't be same (backport [#36973](#36973)) ([#37071](#37071)) ([b56c9b9](b56c9b9))
* after applying coupon code, field in_words not updated ([#37133](#37133)) ([1cb8c64](1cb8c64))
* Apply dimension filter, irrespective of dimesion columns ([9bc44a3](9bc44a3))
* asset validation misfire on debit notes ([b33db6c](b33db6c))
* company wise deferred accounting fields in item ([#37023](#37023)) ([13aaff3](13aaff3))
* Don't allow merging accounts with different currency ([#37074](#37074)) ([c41cb39](c41cb39))
* don't set from warehouse for purchase material request ([#37132](#37132)) ([e62b783](e62b783))
* Duplicate Serial Nos validation in POS ([#36927](#36927)) ([366325c](366325c))
* fetch logic for repay_from_salary in loan_repayment [v14] ([#37135](#37135)) ([480a0ca](480a0ca))
* ignore user permissions for `Source Warehouse` in MR (backport [#37102](#37102)) ([#37110](#37110)) ([727dcc5](727dcc5))
* incorrect stock ledger entries in DN (backport [#36944](#36944)) ([#37066](#37066)) ([699ad80](699ad80))
* packed item using expired price ([413b40f](413b40f))
* POS opening Issue if Product Bundle is available ([#37138](#37138)) ([af05864](af05864))
* precision issue and column name ([#37073](#37073)) ([f2395a9](f2395a9))
* Purchase Receipt Provisional Accounting GL Entries (backport [#37046](#37046)) ([#37068](#37068)) ([8772e40](8772e40))
* Remove redundant code ([#37001](#37001)) ([3ecdf02](3ecdf02))
* **ux:** move `get_route_options_for_new_doc` to `refresh` ([#37092](#37092)) ([a563fed](a563fed))
* validate duplicate serial no in DN ([fffa13f](fffa13f))

### Features

* provision to create RIV from `Stock Ledger Invariant Check` report (backport [#37115](#37115)) ([#37147](#37147)) ([29ff0ce](29ff0ce))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant