Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AP & AR summary filters to match AR #37248

Merged
merged 3 commits into from
Sep 27, 2023
Merged

fix: AP & AR summary filters to match AR #37248

merged 3 commits into from
Sep 27, 2023

Conversation

GursheenK
Copy link
Member

Problem

  • After the AP / AR Report filters got renamed, the AP and AR Summary filters stopped working due to the common run method used by all of these reports.
  • The Process Statement of Accounts also uses the old filters.

Solution

  • Updated AR and AP Summary filters to match that of AR.
  • Set the Process SOA filters with the new name.

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 26, 2023
@ruthra-kumar ruthra-kumar self-assigned this Sep 27, 2023
@ruthra-kumar ruthra-kumar merged commit a223935 into frappe:develop Sep 27, 2023
12 of 13 checks passed
@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Sep 27, 2023
@mergify mergify bot mentioned this pull request Sep 27, 2023
Merged
deepeshgarg007 pushed a commit that referenced this pull request Sep 27, 2023
@mergify @GursheenK
fix: AP & AR summary filters to match AR (backport #37248) (#37261)
1dc58b3 
* fix: set AR filters after rename

(cherry picked from commit 832d7e7)

* fix: change filters for AR summary

(cherry picked from commit 7d96044)

* fix: set new AP summary filters

(cherry picked from commit 76a5d94)

---------

Co-authored-by: Gursheen Anand <gursheen@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request Sep 27, 2023
@frappe-bot
chore(release): Bumped to Version 14.41.0
abb6044 
# [14.41.0](v14.40.0...v14.41.0) (2023-09-27)

### Bug Fixes

* allow to select parent warehouse in the website item (backport [#37047](#37047)) ([#37173](#37173)) ([56657b6](56657b6))
* AP & AR summary filters to match AR  (backport [#37248](#37248)) ([#37261](#37261)) ([1dc58b3](1dc58b3))
* apply gl report filters ([b4bc44d](b4bc44d))
* german translation of Sales and Purchase Invoice ([#37122](#37122)) ([8236814](8236814))
* incorrect `Parent Task` getting set for 2nd to nth child Task (backport [#37230](#37230)) ([#37240](#37240)) ([279f21d](279f21d))
* labels for `Stock Ledger Invariant Check` report (backport [#37150](#37150)) ([#37176](#37176)) ([f2bcfb5](f2bcfb5))
* **Material Request:** consider project for item details (backport [#37215](#37215)) ([#37221](#37221)) ([25f800d](25f800d))
* reserved qty for production plan ([#37251](#37251)) ([0a0d5b3](0a0d5b3))
* serial number decimal issue ([#37242](#37242)) ([78ab201](78ab201))
* set customer currency in pos_invoice if exists ([e0da8d2](e0da8d2))
* Update `advance_paid` in SO/PO after unlinking from advance entry ([1181dcf](1181dcf))
* validate duplicate serial no on submit in DN ([#37243](#37243)) ([70e2093](70e2093))

### Features

* `Stock Ledger Variance` report (backport [#37165](#37165)) ([#37183](#37183)) ([02fc67c](02fc67c))
* Toggle net values in Trial Balance report ([57c82c1](57c82c1))
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees

@ruthra-kumar ruthra-kumar

Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GursheenK @ruthra-kumar