Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: set exchange rate on foreign currency JE from Bank Reconciliation #37625

Conversation

ruthra-kumar
Copy link
Member

While making foreign currency Journal Entries from Bank Reconciliation, set exchange rate and, Debit and Credit values based on that exchange rate.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 22, 2023
@ruthra-kumar ruthra-kumar force-pushed the set_multi_currency_fields_for_je_in_bank_reconciliation branch from ad367b9 to 89f4842 Compare October 24, 2023 01:11
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #37625 (74a0d64) into develop (514d543) will decrease coverage by 0.02%.
Report is 49 commits behind head on develop.
The diff coverage is 74.40%.

@@             Coverage Diff             @@
##           develop   #37625      +/-   ##
===========================================
- Coverage    67.34%   67.32%   -0.02%     
===========================================
  Files          757      757              
  Lines        60098    60144      +46     
===========================================
+ Hits         40472    40491      +19     
- Misses       19626    19653      +27     
Files Coverage Δ
erpnext/accounts/general_ledger.py 90.55% <ø> (ø)
...g/doctype/supplier_scorecard/supplier_scorecard.py 55.97% <ø> (ø)
erpnext/manufacturing/doctype/bom/bom.py 78.49% <100.00%> (ø)
erpnext/setup/doctype/company/company.py 74.21% <ø> (ø)
erpnext/stock/get_item_details.py 83.06% <100.00%> (ø)
erpnext/stock/stock_ledger.py 84.53% <100.00%> (ø)
...ounts/doctype/purchase_invoice/purchase_invoice.py 84.29% <93.33%> (ø)
erpnext/setup/doctype/employee/employee.py 57.76% <0.00%> (ø)
...ype/closing_stock_balance/closing_stock_balance.py 74.32% <66.66%> (ø)
...e/subcontracting_receipt/subcontracting_receipt.py 89.53% <0.00%> (ø)
... and 5 more

... and 7 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit 7c1b990 into frappe:develop Oct 25, 2023
13 checks passed
@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Oct 25, 2023
ruthra-kumar added a commit that referenced this pull request Oct 25, 2023
…-37625

refactor: set exchange rate on foreign currency JE from Bank Reconciliation (backport #37625)
ruthra-kumar added a commit that referenced this pull request Dec 15, 2023
…-37625

refactor: set exchange rate on foreign currency JE from Bank Reconciliation (backport #37625)
@ruthra-kumar
Copy link
Member Author

@mergify backport version-15

Copy link
Contributor

mergify bot commented Dec 15, 2023

backport version-15

✅ Backports have been created

ruthra-kumar added a commit that referenced this pull request Dec 15, 2023
refactor: set exchange rate on foreign currency JE from Bank Reconciliation (backport #37625)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant