Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: configurable exchange gain or loss posting date #37630

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Oct 22, 2023

In Payment Reconciliation, the pop-up for settings difference amount will have posting date field as well.

Screenshot 2023-10-22 at 8 58 25 PM

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Oct 22, 2023
@ruthra-kumar ruthra-kumar force-pushed the provision_to_set_for_gain_loss_journal branch from 436f7f3 to 93f3c60 Compare October 23, 2023 05:22
@ruthra-kumar ruthra-kumar force-pushed the provision_to_set_for_gain_loss_journal branch 2 times, most recently from da068ab to 514d543 Compare October 23, 2023 15:05
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #37630 (514d543) into develop (38ca164) will increase coverage by 0.47%.
Report is 133 commits behind head on develop.
The diff coverage is 77.27%.

@@             Coverage Diff             @@
##           develop   #37630      +/-   ##
===========================================
+ Coverage    66.86%   67.34%   +0.47%     
===========================================
  Files          791      757      -34     
  Lines        62519    60098    -2421     
===========================================
- Hits         41805    40472    -1333     
+ Misses       20714    19626    -1088     
Files Coverage Δ
...account_closing_balance/account_closing_balance.py 97.91% <100.00%> (+4.29%) ⬆️
...xt/accounts/doctype/payment_entry/payment_entry.py 83.77% <100.00%> (+0.08%) ⬆️
...e/payment_reconciliation/payment_reconciliation.py 93.79% <100.00%> (+0.02%) ⬆️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 83.88% <100.00%> (-0.08%) ⬇️
...nts/doctype/subscription_plan/subscription_plan.py 40.47% <ø> (ø)
erpnext/accounts/doctype/tax_rule/tax_rule.py 93.10% <100.00%> (+1.36%) ⬆️
.../report/accounts_receivable/accounts_receivable.py 90.56% <100.00%> (ø)
...omparison/general_and_payment_ledger_comparison.py 100.00% <100.00%> (ø)
erpnext/accounts/utils.py 73.16% <100.00%> (-1.60%) ⬇️
erpnext/controllers/selling_controller.py 79.88% <100.00%> (-0.88%) ⬇️
... and 37 more

... and 18 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit 025acc0 into frappe:develop Oct 23, 2023
20 of 23 checks passed
@ruthra-kumar ruthra-kumar added backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Oct 23, 2023
ruthra-kumar added a commit that referenced this pull request Oct 24, 2023
…-37630

refactor: configurable exchange gain or loss posting date (backport #37630)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants