-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: configurable exchange gain or loss posting date #37630
Merged
ruthra-kumar
merged 4 commits into
frappe:develop
from
ruthra-kumar:provision_to_set_for_gain_loss_journal
Oct 23, 2023
Merged
refactor: configurable exchange gain or loss posting date #37630
ruthra-kumar
merged 4 commits into
frappe:develop
from
ruthra-kumar:provision_to_set_for_gain_loss_journal
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
requested review from
deepeshgarg007 and
rohitwaghchaure
as code owners
October 22, 2023 15:31
github-actions
bot
added
accounts
needs-tests
This PR needs automated unit-tests.
labels
Oct 22, 2023
erpnext/accounts/doctype/accounts_settings/accounts_settings.json
Outdated
Show resolved
Hide resolved
ruthra-kumar
force-pushed
the
provision_to_set_for_gain_loss_journal
branch
from
October 23, 2023 05:22
436f7f3
to
93f3c60
Compare
ruthra-kumar
force-pushed
the
provision_to_set_for_gain_loss_journal
branch
2 times, most recently
from
October 23, 2023 15:05
da068ab
to
514d543
Compare
Codecov Report
@@ Coverage Diff @@
## develop #37630 +/- ##
===========================================
+ Coverage 66.86% 67.34% +0.47%
===========================================
Files 791 757 -34
Lines 62519 60098 -2421
===========================================
- Hits 41805 40472 -1333
+ Misses 20714 19626 -1088
|
ruthra-kumar
added
backport version-14-hotfix
backport to version 14
and removed
needs-tests
This PR needs automated unit-tests.
labels
Oct 23, 2023
ruthra-kumar
added a commit
that referenced
this pull request
Oct 24, 2023
…-37630 refactor: configurable exchange gain or loss posting date (backport #37630)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Payment Reconciliation, the pop-up for settings difference amount will have posting date field as well.