fix: validate sales order item with quotation #37635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GursheenK
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
deepeshgarg007
added
backport version-14-hotfix
This was referenced Nov 1, 2023
deepeshgarg007
added a commit
that referenced
this pull request
Nov 1, 2023
…-37635 fix: validate sales order item with quotation (backport #37635)
deepeshgarg007
added a commit
that referenced
this pull request
Nov 1, 2023
…-37635 fix: validate sales order item with quotation (#37635)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
System allows the creation of a Sales Order with items that have reference to a Quotation even when the Quotation does not consist of the item.
This leads to a Quotation with a different set of items as the Sales Order.
The status of the Quotation is shown as Partially Ordered even though none of the items from the Quotation were actually Ordered.
Fix
Added validation for ensuring that if a SO Item has reference to a Quotation, it is present in the Quotation.
no-docs