fix: issue occured when creating supplier with contact details #38147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunhimohamed
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #38147 +/- ##
========================================
Coverage 67.26% 67.26%
========================================
Files 757 757
Lines 60487 60493 +6
========================================
+ Hits 40684 40691 +7
+ Misses 19803 19802 -1
|
deepeshgarg007
added a commit
that referenced
this pull request
Nov 19, 2023
…-38147 fix: issue occured when creating supplier with contact details (#38147)
rohitwaghchaure
added a commit
that referenced
this pull request
Dec 31, 2023
…ort #38147) (#39046) * fix: issue occured when creating supplier with contact details (cherry picked from commit 7842c9f) # Conflicts: # erpnext/selling/doctype/customer/customer.py * fix: Suppier name was not taken when creating address from supplier (cherry picked from commit 545ef3c) * chore: fix conflicts * chore: fix linter issues --------- Co-authored-by: kunhi <kunhimohamed6@gmail.com> Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
# [14.58.0](v14.57.0...v14.58.0) (2024-01-03) ### Bug Fixes * Add missing french translations (backport [#38368](#38368)) ([#38513](#38513)) ([2c90ee2](2c90ee2)) * **DX:** capture tracebacks with context (backport [#39060](#39060)) ([#39062](#39062)) ([fe9acc8](fe9acc8)) * **Hierarchy Chart:** check if company is set before loading children ([#38985](#38985)) ([e4d6df3](e4d6df3)) * issue occured when creating supplier with contact details (backport [#38147](#38147)) ([#39046](#39046)) ([81ef7b4](81ef7b4)) * Opening balance in bank reconciliation tool ([#38977](#38977)) ([a2cba1b](a2cba1b)) * remove bad defaults (backport [#38986](#38986)) ([#38987](#38987)) ([29d383a](29d383a)) * select options should dynamically load dimensions ([bfc94cf](bfc94cf)) * take quantity into account when setting asset's gross purchase amt (backport [#39056](#39056)) ([#39057](#39057)) ([b8dce3e](b8dce3e)) * undefined error in Budget Variance and Profitability report ([cad15cd](cad15cd)) * use `Stock Qty` while getting `POS Reserved Qty` (backport [#38962](#38962)) ([#38982](#38982)) ([7ad42ec](7ad42ec)) * Validate account in Sales/Purchase Taxes and Charges Template ([#39013](#39013)) ([c0b5980](c0b5980)) * work order with multi level, fetch operting cost from sub-assembly (backport [#38992](#38992)) ([#39027](#39027)) ([88e5c9e](88e5c9e)) ### Features * Merge taxes from mapped docs ([#38346](#38346)) ([c74e6aa](c74e6aa)) * Show Ledger view for Purchase & Sales Register ([#38801](#38801)) ([04fb215](04fb215)) ### Performance Improvements * index item_code in bom explosion item (backport [#39085](#39085)) ([#39087](#39087)) ([558861b](558861b))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Against the Issue 38124