refactor: convert Payment Reconciliation to virtual doctype #38148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #38148 +/- ##
========================================
Coverage 67.26% 67.26%
========================================
Files 757 757
Lines 60492 60512 +20
========================================
+ Hits 40689 40703 +14
- Misses 19803 19809 +6
|
ruthra-kumar
force-pushed
the
prevent_lock_on_reconciliation
branch
from
56f0b00
to
a9a9460
Compare
ruthra-kumar
force-pushed
the
prevent_lock_on_reconciliation
branch
from
a9a9460
to
f310026
Compare
ruthra-kumar
changed the title
|
Backport this as well: #38283 |
ruthra-kumar
added
backport version-14-hotfix
This was referenced Dec 4, 2023
ruthra-kumar
added a commit
that referenced
this pull request
Dec 4, 2023
…-38148 refactor: convert Payment Reconciliation to virtual doctype (backport #38148)
ruthra-kumar
added a commit
that referenced
this pull request
Dec 4, 2023
…-38148 refactor: convert Payment Reconciliation to virtual doctype (backport #38148)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On large datasets, Payment Reconciliation tool timesout on concurrent usage, with
Lock Wait Timeouterror. This is due to the design of 'Single' doctype, which fetches the values withfor_updatelock by default. To avoids this design bottleneck, the reconciliation tool will be converted to Virtual Doctype.Below doctypes have been converted to Virtual:
Depends on frappe/frappe#23291
Depends on frappe/frappe#23257