fix: valuation rate in report Item Prices #38161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickDEissler
requested review from
rohitwaghchaure and
s-aga-r
as code owners
barredterra
approved these changes
Nov 18, 2023
barredterra
changed the title
barredterra
added
backport version-14-hotfix
mergify bot
pushed a commit
that referenced
this pull request
Nov 18, 2023
Co-authored-by: PatrickDenis-stack <77415730+PatrickDenis-stack@users.noreply.github.com> (cherry picked from commit 32f622e)
mergify bot
pushed a commit
that referenced
this pull request
Nov 18, 2023
Co-authored-by: PatrickDenis-stack <77415730+PatrickDenis-stack@users.noreply.github.com> (cherry picked from commit 32f622e)
deepeshgarg007
added a commit
that referenced
this pull request
Nov 19, 2023
…-38161 fix: valuation rate in report Item Prices (#38161)
deepeshgarg007
added a commit
that referenced
this pull request
Nov 19, 2023
…-38161 fix: valuation rate in report Item Prices (#38161)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
# [15.3.0](v15.2.0...v15.3.0) (2023-11-21) ### Bug Fixes * attributes were mandatory for manufacturers ([00b9c23](00b9c23)) * issue occured when creating supplier with contact details ([aaccfeb](aaccfeb)) * overallocation on Payment with PO/SO ([337707b](337707b)) * pass check permission in render_address ([a420e13](a420e13)) * payment entry rounding error ([384d6b5](384d6b5)) * set asset's valuation_rate according to asset quantity (backport [#38254](#38254)) ([#38256](#38256)) ([c60aaa7](c60aaa7)) * set default asset quantity as 1 [dev] (backport [#38223](#38223)) ([#38226](#38226)) ([99bf63e](99bf63e)) * Suppier name was not taken when creating address from supplier ([2b94489](2b94489)) * Supplier Quotation fields ([#37963](#37963)) ([aef955c](aef955c)) * test case for rounded total with cash disc ([eab18e6](eab18e6)) * **Timesheet:** reset billing hours equal to hours if they exceed actual hours (backport [#38134](#38134)) ([#38153](#38153)) ([5b7b431](5b7b431)) * **Timesheet:** warn user if billing hours > actual hours instead of resetting (backport [#38239](#38239)) ([#38241](#38241)) ([1f2f5d8](1f2f5d8)) * TypeError in Subcontracting Receipt (backport [#38200](#38200)) ([#38208](#38208)) ([3f57a7e](3f57a7e)) * update modified timestamp ([a492e57](a492e57)) * **ux:** `Task` creation from `Timesheet` (backport [#38207](#38207)) ([#38211](#38211)) ([e272041](e272041)) * valuation rate for FG item for subcontracting receipt (backport [#38244](#38244)) ([#38245](#38245)) ([ed7b845](ed7b845)) * valuation rate in report Item Prices ([#38161](#38161)) ([f71234e](f71234e)) * wrong round off and rounded total ([70eccf7](70eccf7)) ### Features * add `Supplier Delivery Note` field in SCR (backport [#38127](#38127)) ([#38156](#38156)) ([b89a4a7](b89a4a7)) * Add accounting dimensions to Supplier Quotation ([7d4ac7e](7d4ac7e))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
# [14.49.0](v14.48.1...v14.49.0) (2023-11-22) ### Bug Fixes * add revaluation journal filter in Payable report ([d0698b3](d0698b3)) * attributes were mandatory for manufacturers ([430980a](430980a)) * duplicate field in `Closing Stock Balance` ([#38105](#38105)) ([1f16c47](1f16c47)) * incorrect incoming rate for serial and batch items in standalone debit note ([#38121](#38121)) ([9a34518](9a34518)) * pass check permission in render_address ([1ccd5e4](1ccd5e4)) * payment entry rounding error ([49735bc](49735bc)) * remove ESS role when not mapped to employee (backport [#37867](#37867)) ([#38132](#38132)) ([bc01007](bc01007)) * round `unreconciled_amount` before asserting ([392ee2e](392ee2e)) * set asset's valuation_rate according to asset quantity (backport [#38254](#38254)) ([#38255](#38255)) ([00def82](00def82)) * set default asset quantity as 1 [v14] ([#38224](#38224)) ([3daf6f8](3daf6f8)) * show party values when naming by is not naming series ([dd76695](dd76695)) * Supplier Quotation fields ([#37963](#37963)) ([883eaee](883eaee)) * test case for rounded total with cash disc ([9b5185a](9b5185a)) * **Timesheet:** reset billing hours equal to hours if they exceed actual hours (backport [#38134](#38134)) ([#38152](#38152)) ([c7c751e](c7c751e)) * **Timesheet:** warn user if billing hours > actual hours instead of resetting (backport [#38239](#38239)) ([#38240](#38240)) ([e08f114](e08f114)) * update modified timestamp ([2849e0d](2849e0d)) * valuation rate in report Item Prices ([#38161](#38161)) ([a70696e](a70696e)) * wrong round off and rounded total ([296433a](296433a)) ### Features * add `Supplier Delivery Note` field in SCR (backport [#38127](#38127)) ([#38155](#38155)) ([8d4a19c](8d4a19c)) * Add accounting dimensions to Supplier Quotation ([51e33e1](51e33e1)) * virtual parent doctype ([8dbf2ce](8dbf2ce))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Valuation rates were printed as 0,00 in the Report Item Prices.
Cause: Missing brackets.
Effect in backend: item_val_rate_map was a dictionary that looked like this: {item_code: None}
With the brackets it works:
