Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude invoice_doctypes from party advance #38220

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

rtdany10
Copy link
Contributor

Partially solves #38130

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #38220 (f34ffc2) into develop (a9bf906) will decrease coverage by 0.01%.
Report is 29 commits behind head on develop.
The diff coverage is 87.50%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38220      +/-   ##
===========================================
- Coverage    67.26%   67.26%   -0.01%     
===========================================
  Files          757      757              
  Lines        60500    60505       +5     
===========================================
+ Hits         40698    40701       +3     
- Misses       19802    19804       +2     
Files Coverage Δ
erpnext/accounts/party.py 81.12% <100.00%> (+0.09%) ⬆️
erpnext/controllers/taxes_and_totals.py 95.30% <100.00%> (ø)
erpnext/hooks.py 100.00% <ø> (ø)
erpnext/stock/report/item_prices/item_prices.py 94.80% <ø> (ø)
erpnext/selling/doctype/customer/customer.py 76.48% <80.00%> (ø)

... and 4 files with indirect coverage changes

@rtdany10
Copy link
Contributor Author

@ruthra-kumar

@ruthra-kumar ruthra-kumar self-assigned this Nov 30, 2023
@ruthra-kumar ruthra-kumar merged commit 94fabe0 into frappe:develop Dec 4, 2023
14 checks passed
ruthra-kumar added a commit that referenced this pull request Dec 4, 2023
…-38220

fix: exclude `invoice_doctypes` from party advance (backport #38220)
ruthra-kumar added a commit that referenced this pull request Dec 4, 2023
…-38220

fix: exclude `invoice_doctypes` from party advance (backport #38220)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants