Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pe): show split alert only on splitting #38440

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

rtdany10
Copy link
Contributor

Introduced via: #37859

Split message pops up even if there is no payment terms wise splitting.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 30, 2023
@rtdany10
Copy link
Contributor Author

Please backport to v15 and v14

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #38440 (96b13c5) into develop (591f4eb) will decrease coverage by 0.01%.
Report is 4 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38440      +/-   ##
===========================================
- Coverage    67.25%   67.25%   -0.01%     
===========================================
  Files          760      760              
  Lines        60853    60854       +1     
===========================================
  Hits         40928    40928              
- Misses       19925    19926       +1     
Files Coverage Δ
...xt/accounts/doctype/payment_entry/payment_entry.py 83.67% <100.00%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes

@ruthra-kumar ruthra-kumar self-assigned this Nov 30, 2023
@ruthra-kumar ruthra-kumar merged commit 9656412 into frappe:develop Dec 1, 2023
14 checks passed
@ruthra-kumar ruthra-kumar added backport version-14-hotfix backport to version 14 backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Dec 1, 2023
ruthra-kumar added a commit that referenced this pull request Dec 1, 2023
…-38440

fix(pe): show split alert only on splitting (backport #38440)
barredterra added a commit that referenced this pull request Dec 15, 2023
fix(pe): show split alert only on splitting (backport #38440)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants