Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pass on filter to up front outstanding query as well #38446

Merged

Conversation

ruthra-kumar
Copy link
Member

regression: #38257

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Nov 30, 2023
@ruthra-kumar ruthra-kumar changed the title refactor: pass on filter to upfront outstanding query as well refactor: pass on filter to up front outstanding query as well Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #38446 (cfd3230) into develop (8c3713b) will increase coverage by 0.02%.
Report is 56 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38446      +/-   ##
===========================================
+ Coverage    67.23%   67.25%   +0.02%     
===========================================
  Files          758      760       +2     
  Lines        60619    60852     +233     
===========================================
+ Hits         40756    40927     +171     
- Misses       19863    19925      +62     
Files Coverage Δ
erpnext/accounts/utils.py 73.27% <ø> (ø)

... and 15 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit de3795a into frappe:develop Nov 30, 2023
15 checks passed
ruthra-kumar added a commit that referenced this pull request Nov 30, 2023
…-38446

refactor: pass on filter to up front outstanding query as well (backport #38446)
ruthra-kumar added a commit that referenced this pull request Nov 30, 2023
…-38446

refactor: pass on filter to up front outstanding query as well (backport #38446)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant