Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use flt on outstanding on AR/AP summary report #38457

Conversation

ruthra-kumar
Copy link
Member

Prevent parties without outstanding from being reported due to rounding loss.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #38457 (e4bdd3a) into develop (8c3713b) will decrease coverage by 7.11%.
Report is 60 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38457      +/-   ##
===========================================
- Coverage    67.23%   60.12%   -7.11%     
===========================================
  Files          758      760       +2     
  Lines        60619    69444    +8825     
===========================================
+ Hits         40756    41754     +998     
- Misses       19863    27690    +7827     
Files Coverage Δ
..._receivable_summary/accounts_receivable_summary.py 92.23% <100.00%> (+0.07%) ⬆️

... and 493 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit cc053ad into frappe:develop Nov 30, 2023
12 of 14 checks passed
@ruthra-kumar
Copy link
Member Author

@mergify backport version-14

Copy link
Contributor

mergify bot commented Nov 30, 2023

backport version-14

✅ Backports have been created

ruthra-kumar added a commit that referenced this pull request Nov 30, 2023
…-38457

refactor: use flt on outstanding on AR/AP summary report (backport #38457)
ruthra-kumar added a commit that referenced this pull request Nov 30, 2023
…-38457

refactor: use flt on outstanding on AR/AP summary report (backport #38457)
ruthra-kumar added a commit that referenced this pull request Nov 30, 2023
fix: use flt on outstanding on AR/AP summary report (backport #38457)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant