Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set lead name from email #38505

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Dec 1, 2023

Depends on frappe/frappe#23554

Scenario:

A new Lead is created from an email with sender "Jane Doe <jane@example.org>"

Old behavior:

  • Full Name set to "jane",
  • First Name empty,
  • Last Name empty.

New behavior:

  • Full Name set to "Jane Doe",
  • First Name set to "Jane",
  • Last Name set to "Doe".

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 1, 2023
@barredterra barredterra marked this pull request as draft December 1, 2023 19:17
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #38505 (ceeb724) into develop (961bdf0) will increase coverage by 0.00%.
Report is 78 commits behind head on develop.
The diff coverage is 12.62%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #38505   +/-   ##
========================================
  Coverage    60.15%   60.15%           
========================================
  Files          760      760           
  Lines        69470    69476    +6     
========================================
+ Hits         41791    41795    +4     
- Misses       27679    27681    +2     
Files Coverage Δ
...xt/accounts/doctype/payment_entry/payment_entry.py 84.21% <100.00%> (+0.01%) ⬆️
..._receivable_summary/accounts_receivable_summary.py 92.23% <100.00%> (ø)
erpnext/accounts/utils.py 73.79% <ø> (ø)
erpnext/controllers/sales_and_purchase_return.py 87.26% <100.00%> (ø)
erpnext/controllers/selling_controller.py 79.94% <ø> (ø)
erpnext/controllers/subcontracting_controller.py 89.55% <100.00%> (ø)
erpnext/hooks.py 100.00% <100.00%> (ø)
erpnext/__init__.py 70.00% <0.00%> (ø)
...unts/report/purchase_register/purchase_register.py 86.33% <50.00%> (ø)
...t/accounts/report/sales_register/sales_register.py 70.35% <50.00%> (ø)
... and 265 more

... and 3 files with indirect coverage changes

@barredterra barredterra marked this pull request as ready for review December 4, 2023 14:39
@barredterra barredterra merged commit e7544e9 into frappe:develop Dec 14, 2023
13 of 23 checks passed
@barredterra barredterra deleted the lead_name_from_email branch December 14, 2023 12:48
@barredterra barredterra added backport version-14-hotfix backport to version 14 backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Dec 14, 2023
deepeshgarg007 added a commit that referenced this pull request Dec 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants