Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SO ordered qty on PO item removal (backport #38378) #38517

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 2, 2023

This is an automatic backport of pull request #38378 done by Mergify.
Cherry-pick of 9087e14 has failed:

On branch mergify/bp/version-14-hotfix/pr-38378
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 9087e1443e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   erpnext/controllers/accounts_controller.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/buying/doctype/purchase_order/purchase_order.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* fix: update ordered_qty for SO when PO items removed

* refactor: use cached value

---------

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
(cherry picked from commit 9087e14)

# Conflicts:
#	erpnext/buying/doctype/purchase_order/purchase_order.py
@mergify mergify bot added the conflicts label Dec 2, 2023
@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Dec 2, 2023
@deepeshgarg007 deepeshgarg007 merged commit b7fe163 into version-14-hotfix Dec 4, 2023
10 checks passed
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-38378 branch December 4, 2023 04:06
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts needs-tests This PR needs automated unit-tests. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants