Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Consolidate duplicate zero-quantity Items checks for transactions. #38530

Merged
merged 3 commits into from
Jan 9, 2024

chore: Adapt translations to reworded message.

3688d94
Select commit
Loading
Failed to load commit list.
Merged

refactor: Consolidate duplicate zero-quantity Items checks for transactions. #38530

chore: Adapt translations to reworded message.
3688d94
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 8, 2024 in 1s

63.74% (+3.57%) compared to 64266c4

View this Pull Request on Codecov

63.74% (+3.57%) compared to 64266c4

Details

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (64266c4) 60.16% compared to head (3688d94) 63.74%.
Report is 321 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38530      +/-   ##
===========================================
+ Coverage    60.16%   63.74%   +3.57%     
===========================================
  Files          759      761       +2     
  Lines        69464    80912   +11448     
===========================================
+ Hits         41794    51578    +9784     
- Misses       27670    29334    +1664     
Files Coverage Δ
...ounts/doctype/purchase_invoice/purchase_invoice.py 73.77% <ø> (+3.64%) ⬆️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 80.47% <ø> (+6.46%) ⬆️
...ype/request_for_quotation/request_for_quotation.py 53.20% <100.00%> (+3.60%) ⬆️
...g/doctype/supplier_quotation/supplier_quotation.py 40.39% <ø> (ø)
erpnext/buying/utils.py 81.03% <ø> (+0.38%) ⬆️
erpnext/controllers/buying_controller.py 85.76% <ø> (+1.82%) ⬆️
erpnext/controllers/sales_and_purchase_return.py 90.90% <ø> (+3.68%) ⬆️
erpnext/controllers/selling_controller.py 81.56% <100.00%> (+1.62%) ⬆️
erpnext/controllers/subcontracting_controller.py 89.55% <ø> (ø)
erpnext/selling/doctype/quotation/quotation.py 43.75% <ø> (ø)
... and 10 more

... and 74 files with indirect coverage changes