fix: calc monthly_repayment_amount correctly in regenerate_repayment_schedule #38636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
# [14.54.0](v14.53.0...v14.54.0) (2023-12-12) ### Bug Fixes * 1st row depr. sch. value of asset put to less than 180 days acc. to I.T. S. 32 ([#38697](#38697)) ([753a1b5](753a1b5)) * calc monthly_repayment_amount correctly in regenerate_repayment_schedule ([#38636](#38636)) ([008400d](008400d)) * format only if searched text contain link value text ([b28deaa](b28deaa)) * limit end date to current date ([cbe15e1](cbe15e1)) * typo in unittest ([#38673](#38673)) ([c87a3c7](c87a3c7)) * **ux:** don't update qty blindly (backport [#38608](#38608)) ([#38638](#38638)) ([29cd474](29cd474)) ### Features * add employee number to client user bootinfo (backport [#38477](#38477)) ([#38602](#38602)) ([c2a137f](c2a137f)) ### Reverts * Revert "refactor: bank transaction (backport #38182)" (#38653) ([7813efa](7813efa)), closes [#38182](#38182) [#38653](#38653) [#38182](#38182)
|
🎉 This PR is included in version 14.54.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monthly_repayment_amount in regenerate_repayment_schedule was being calculated incorrectly so fixed that by using the correct repayment schedule length and putting missing brackets.