Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: groups for current accounts in German CoAs #38803

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Dec 16, 2023

  • Rename "Trade receivables" to "Trade receivables with current account" and convert to group. Add single account "Trade receivables without current account".
  • Rename "Trade payables" to "Trade payables with current account" and convert to group. Add single account "Trade payables without current account".
  • Remove redundant "Debtors" and "Creditors" groups

This only affects new sites/companies and makes sure they start off with a more correct CoA.

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Merging #38803 (259f313) into develop (5a83a16) will increase coverage by 0.02%.
Report is 55 commits behind head on develop.
The diff coverage is 90.90%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38803      +/-   ##
===========================================
+ Coverage    60.08%   60.10%   +0.02%     
===========================================
  Files          759      759              
  Lines        69556    69648      +92     
===========================================
+ Hits         41790    41861      +71     
- Misses       27766    27787      +21     
Files Coverage Δ
...unts/report/purchase_register/purchase_register.py 86.33% <ø> (ø)
erpnext/accounts/utils.py 73.82% <ø> (+0.03%) ⬆️
erpnext/controllers/accounts_controller.py 85.14% <100.00%> (+0.04%) ⬆️
...tax_withholding_details/tax_withholding_details.py 80.12% <66.66%> (ø)

... and 17 files with indirect coverage changes

@barredterra barredterra merged commit 42813d3 into frappe:develop Dec 17, 2023
15 checks passed
@barredterra barredterra deleted the group-current-accounts branch December 17, 2023 18:23
barredterra added a commit that referenced this pull request Dec 17, 2023
…-38803

fix: groups for current accounts in German CoAs (backport #38803)
deepeshgarg007 added a commit that referenced this pull request Dec 22, 2023
…-38803

fix: groups for current accounts in German CoAs (#38803)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant