Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): Demo setup for Canadian COA #38807

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Dec 17, 2023

Because of missing default inventory and income account, demo data setup for Canadian Companies using default COA fails

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 17, 2023
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Merging #38807 (c9fd182) into develop (be312ce) will increase coverage by 0.03%.
Report is 99 commits behind head on develop.
The diff coverage is 38.46%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38807      +/-   ##
===========================================
+ Coverage    60.15%   60.19%   +0.03%     
===========================================
  Files          759      759              
  Lines        69487    69759     +272     
===========================================
+ Hits         41798    41988     +190     
- Misses       27689    27771      +82     
Files Coverage Δ
erpnext/setup/demo.py 94.11% <100.00%> (ø)
erpnext/controllers/accounts_controller.py 85.14% <75.00%> (+0.08%) ⬆️
...serial_and_batch_bundle/serial_and_batch_bundle.py 71.78% <25.00%> (+0.63%) ⬆️

... and 38 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit 5514778 into frappe:develop Dec 17, 2023
15 checks passed
deepeshgarg007 added a commit that referenced this pull request Dec 17, 2023
…-38807

fix(demo): Demo setup for Canadian COA (#38807)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant