-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use party account currency when party account is specified #38838
Merged
ruthra-kumar
merged 2 commits into
frappe:develop
from
pps190:fix-use-party-account-currency
Dec 20, 2023
Merged
fix: use party account currency when party account is specified #38838
ruthra-kumar
merged 2 commits into
frappe:develop
from
pps190:fix-use-party-account-currency
Dec 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj12djdjs
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
December 18, 2023 18:09
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #38838 +/- ##
========================================
Coverage 60.18% 60.19%
========================================
Files 759 759
Lines 69767 69767
========================================
+ Hits 41992 41995 +3
+ Misses 27775 27772 -3
|
@dj12djdjs Looks good to me. |
ruthra-kumar
added
backport version-14-hotfix
backport to version 14
backport version-15-hotfix
labels
Dec 20, 2023
This was referenced Dec 20, 2023
ruthra-kumar
added a commit
that referenced
this pull request
Dec 20, 2023
…-38838 fix: use party account currency when party account is specified (backport #38838)
ruthra-kumar
added a commit
that referenced
this pull request
Dec 20, 2023
…-38838 fix: use party account currency when party account is specified (backport #38838)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the party account is specified we can show the records in the currency of the specified parties account. Since a single account is specified, we can show the total row as well.
Reasoning:
In every accounting report when an account is specified, the currency of that account is used by default. For example: General Ledger, when you specify "Debtors USD" it will show the transactions in USD the account currency not the company base currency.