-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: filter project by customer #38934
Conversation
Before: projectnotfiltered.mp4costcentrenotchosen.mp4After: projectfilteredcostcentreset.mp4 |
Failing test doesn't look related. Please let me know if it is. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #38934 +/- ##
===========================================
+ Coverage 60.03% 60.08% +0.04%
===========================================
Files 761 761
Lines 70122 70138 +16
===========================================
+ Hits 42099 42140 +41
+ Misses 28023 27998 -25
|
Closing this PR. Issue should partially be fixed by #39212 set_query for 'project' at individual doctypes can be further tweaked to better handle different scenarios |
Hi @ruthra-kumar , issue is still present as is. The dropdown in the link shows that the customer filter is applied, but the actual results included all Projects regardless of Customer (including cancelled and completed). Please check. |
fixes: #38889