Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter project by customer #38934

Closed
wants to merge 7 commits into from

Conversation

SvbZ3r0
Copy link
Contributor

@SvbZ3r0 SvbZ3r0 commented Dec 24, 2023

fixes: #38889

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 24, 2023
@SvbZ3r0
Copy link
Contributor Author

SvbZ3r0 commented Dec 25, 2023

Before:

projectnotfiltered.mp4
costcentrenotchosen.mp4

After:

projectfilteredcostcentreset.mp4

@SvbZ3r0
Copy link
Contributor Author

SvbZ3r0 commented Dec 25, 2023

Failing test doesn't look related. Please let me know if it is.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (33b631e) 60.03% compared to head (7365a7c) 60.08%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38934      +/-   ##
===========================================
+ Coverage    60.03%   60.08%   +0.04%     
===========================================
  Files          761      761              
  Lines        70122    70138      +16     
===========================================
+ Hits         42099    42140      +41     
+ Misses       28023    27998      -25     
Files Coverage Δ
erpnext/accounts/report/financial_statements.py 82.80% <71.42%> (+2.31%) ⬆️
...serial_and_batch_bundle/serial_and_batch_bundle.py 74.59% <66.66%> (+1.76%) ⬆️
...it_and_loss_statement/profit_and_loss_statement.py 85.88% <69.23%> (+10.55%) ⬆️
erpnext/controllers/queries.py 55.80% <20.00%> (-0.64%) ⬇️

... and 1 file with indirect coverage changes

@ruthra-kumar ruthra-kumar self-assigned this Jan 8, 2024
@ruthra-kumar
Copy link
Member

Closing this PR. Issue should partially be fixed by #39212

set_query for 'project' at individual doctypes can be further tweaked to better handle different scenarios

@SvbZ3r0
Copy link
Contributor Author

SvbZ3r0 commented Jan 9, 2024

Hi @ruthra-kumar , issue is still present as is. The dropdown in the link shows that the customer filter is applied, but the actual results included all Projects regardless of Customer (including cancelled and completed). Please check.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project field filters broken in all DocTypes
2 participants