fix: use local attribute range in multiple item variant dialog #38970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitwaghchaure
approved these changes
Jan 12, 2024
rohitwaghchaure
added
backport version-14-hotfix
This was referenced Jan 12, 2024
rohitwaghchaure
added a commit
that referenced
this pull request
Jan 12, 2024
…-38970 fix: use local attribute range in multiple item variant dialog (backport #38970)
rohitwaghchaure
added a commit
that referenced
this pull request
Jan 12, 2024
…-38970 fix: use local attribute range in multiple item variant dialog (backport #38970)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
When a numeric Item Attribute is created with a default range and added to an Item, the default range is preferred over the item-specific range defined for the attribute while adding Multiple Variants for the Item.
Fix
Use the item-specific range instead of the default range for generating the options in the Variants dialog. The default range is fetched when the attribute is added to the child table, so not editing it will anyway make the logic fall back to use the default range.
Resolves #38705