Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: allow sales invoice in Bank Reconciliation tool (backport #39161) #39183

Merged
merged 1 commit into from
Jan 8, 2024
Merged

refactor: allow sales invoice in Bank Reconciliation tool (backport #39161) #39183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions erpnext/accounts/doctype/bank_transaction/bank_transaction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,15 +366,17 @@ def set_voucher_clearance(doctype, docname, clearance_date, self):
and len(get_reconciled_bank_transactions(doctype, docname)) < 2
):
return
frappe.db.set_value(doctype, docname, "clearance_date", clearance_date)

elif doctype == "Sales Invoice":
frappe.db.set_value(
"Sales Invoice Payment",
dict(parenttype=doctype, parent=docname),
"clearance_date",
clearance_date,
)
if doctype == "Sales Invoice":
frappe.db.set_value(
"Sales Invoice Payment",
dict(parenttype=doctype, parent=docname),
"clearance_date",
clearance_date,
)
return

frappe.db.set_value(doctype, docname, "clearance_date", clearance_date)

elif doctype == "Bank Transaction":
# For when a second bank transaction has fixed another, e.g. refund
Expand Down
1 change: 1 addition & 0 deletions erpnext/hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,7 @@
"Payment Entry",
"Journal Entry",
"Purchase Invoice",
"Sales Invoice",
]

accounting_dimension_doctypes = [
Expand Down
Loading