Change State to State/Province #39223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change Rate label to existing Tax Rate label so it can be correctly translated in other languages
Change Rate label to existing Tax Rate label so it can be correctly translated in other languages
Change Rate label to existing Tax Rate label so it can be correctly translated in other languages
Change Rate label to existing Tax Rate label so it can be correctly translated in other languages
Change Rate label to existing Tax Rate label so it can be correctly translated in other languages
Change Rate label to existing Tax Rate label so it can be correctly translated in other languages
Change Personal to Personal Details to correspond with fieldname as Personal is to generic
deepeshgarg007
approved these changes
Jan 13, 2024
| @@ -253,4 +253,4 @@ | |||
| "sort_order": "ASC", | |||
| "states": [], | |||
| "track_changes": 1 | |||
There was a problem hiding this comment.
Modified date has not updated, due to which this changes won't be reflect on the new site after the migrate
|
@mahsem Please make the change suggested by @rohitwaghchaure and then reopen the PR. Also use semantic commits. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change State to State/Province and sync with frappe existing string