Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(UX): Accounts workspace cleanup #39232

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Jan 9, 2024

  • Breaking down accounting workspace into sub-workspaces
  • Moved Assets outside accounting

image

image image image

@ruchamahabal ruchamahabal marked this pull request as ready for review January 19, 2024 05:20
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (cdd5441) 60.08% compared to head (c8895be) 60.08%.
Report is 245 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #39232      +/-   ##
===========================================
- Coverage    60.08%   60.08%   -0.01%     
===========================================
  Files          761      757       -4     
  Lines        70301    70421     +120     
===========================================
+ Hits         42241    42313      +72     
- Misses       28060    28108      +48     
Files Coverage Δ
...ype/account/chart_of_accounts/chart_of_accounts.py 77.18% <100.00%> (+0.31%) ⬆️
erpnext/accounts/party.py 81.42% <100.00%> (ø)
erpnext/accounts/report/utils.py 78.36% <ø> (ø)
...xt/assets/doctype/asset_activity/asset_activity.py 64.28% <100.00%> (+2.74%) ⬆️
erpnext/setup/demo.py 94.24% <100.00%> (ø)
erpnext/setup/doctype/company/company.py 60.25% <100.00%> (ø)
...doctype/inventory_dimension/inventory_dimension.py 86.66% <100.00%> (ø)
...k/doctype/stock_ledger_entry/stock_ledger_entry.py 70.05% <100.00%> (+0.32%) ⬆️
erpnext/stock/serial_batch_bundle.py 86.58% <ø> (ø)
erpnext/stock/__init__.py 92.68% <0.00%> (ø)
... and 3 more

... and 59 files with indirect coverage changes

@ruchamahabal ruchamahabal merged commit 3506728 into frappe:develop Jan 19, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request Jan 19, 2024
* refactor(UX): Accounts workspace cleanup

* chore: move asset workspace outside accounting

* fix: remove redundant links from parent workspace

* chore: change icons for payable & receivable workspaces

* chore: remove redundant links from subworkspaces

(cherry picked from commit 3506728)

# Conflicts:
#	erpnext/accounts/workspace/accounting/accounting.json
ruchamahabal added a commit that referenced this pull request Jan 19, 2024
* refactor(UX): Accounts workspace cleanup (#39232)

* refactor(UX): Accounts workspace cleanup

* chore: move asset workspace outside accounting

* fix: remove redundant links from parent workspace

* chore: change icons for payable & receivable workspaces

* chore: remove redundant links from subworkspaces

(cherry picked from commit 3506728)

* chore: fix conflicts

---------

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant