Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sales team commission overallocation on fetching items from multiple quotations to Sales Order #39237

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix: sales team commission overallocation on fetching items from multiple quotations to Sales Order #39237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions erpnext/selling/doctype/quotation/quotation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,15 +370,16 @@ def set_missing_values(source, target):
)

# sales team
for d in customer.get("sales_team") or []:
target.append(
"sales_team",
{
"sales_person": d.sales_person,
"allocated_percentage": d.allocated_percentage or None,
"commission_rate": d.commission_rate,
},
)
if not target.get("sales_team"):
for d in customer.get("sales_team") or []:
target.append(
"sales_team",
{
"sales_person": d.sales_person,
"allocated_percentage": d.allocated_percentage or None,
"commission_rate": d.commission_rate,
},
)

target.flags.ignore_permissions = ignore_permissions
target.delivery_date = nowdate()
Expand Down
Loading