fix: incorrect indicator title for portal sales order (backport #39247) #39254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 2d2ff7c)
mergify
bot
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
# [14.59.0](v14.58.1...v14.59.0) (2024-01-10) ### Bug Fixes * add read permission to Buying Settings (backport [#39158](#39158)) ([#39257](#39257)) ([a15ad80](a15ad80)) * asset WDV depreciation calc according to IT act ([1cbe1e8](1cbe1e8)) * BOM replace tool does not update exploded items of root (backport [#39244](#39244)) ([#39249](#39249)) ([c2eeeec](c2eeeec)) * don't set rate for non-stock item in Internal Transfer (backport [#39140](#39140)) ([#39168](#39168)) ([06d193a](06d193a)) * Duplicate Closing Stock Balance (backport [#39262](#39262)) ([#39263](#39263)) ([a3146c3](a3146c3)) * **Employee:** treeview ([#39126](#39126)) ([080a742](080a742)) * FG Item incorrect qty in the work order (backport [#39200](#39200)) ([#39210](#39210)) ([5e517cf](5e517cf)) * Ignore asset qty and status validation while cancelling LCV ([952cee3](952cee3)) * Ignore UP on "allowed to transact with" (backport [#39103](#39103)) ([#39104](#39104)) ([7d64df0](7d64df0)) * improved validation message ([580e9f6](580e9f6)) * incorrect indicator title for portal sales order (backport [#39247](#39247)) ([#39254](#39254)) ([8c496fb](8c496fb)) * inventory dimension negative stock validation (backport [#39149](#39149)) ([#39150](#39150)) ([2866f7c](2866f7c)) * possible typeerror on transaction.js ([8fe346a](8fe346a)) * Purchase date and amount is not mandatory for composite asset creation ([0f6477a](0f6477a)) * remove global _("translation") calls (backport [#32828](#32828)) ([#39231](#39231)) ([ee7474b](ee7474b)) * resolved conflict ([b529883](b529883)) * set `First Name` in Supplier Contact ([69c460c](69c460c)) * Set asset purchase amount based on qty and valuation_rate ([41e3843](41e3843)) * set parent doctype on chart (backport [#39286](#39286)) ([#39287](#39287)) ([a2a8558](a2a8558)) * Show maintain-stock and is-fixed-asset checkbox in item quick entry dialog ([7b4b630](7b4b630)) * Show timesheet table after fetching data from timesheet (backport [#39275](#39275)) ([#39280](#39280)) ([1cc887a](1cc887a)) * skip rate validation for return `DN Items` with `Moving Average` valuation (backport [#39242](#39242)) ([#39265](#39265)) ([f42e93b](f42e93b)) * total allocated percentage for sales team issue ([71f9b7f](71f9b7f)) * TypeError is pricing rules (backport [#39252](#39252)) ([#39259](#39259)) ([36ba33c](36ba33c)) * typerror on multi select dialog ([71ecf08](71ecf08)) * update Maintenance Schedule status on Maintenance Visit submit (backport [#39167](#39167)) ([#39185](#39185)) ([2ea2146](2ea2146)) * **UX:** dont override framework's permission check messages (backport [#39118](#39118)) ([#39119](#39119)) ([26ae708](26ae708)) ### Features * Copy project_name, from_time, to_time from timesheet details to sales invoice ([#33726](#33726)) ([d0e1162](d0e1162))
|
🎉 This PR is included in version 14.59.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #39247 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com