Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore default payment terms template for opening invoices #39256

Merged

Conversation

deepeshgarg007
Copy link
Member

Fixes: #38389

Opening invoices should not consider default payment terms template

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 89 lines in your changes are missing coverage. Please review.

Comparison is base (33b631e) 60.03% compared to head (53bf44d) 60.04%.
Report is 112 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #39256    +/-   ##
=========================================
  Coverage    60.03%   60.04%            
=========================================
  Files          761      761            
  Lines        70122    70456   +334     
=========================================
+ Hits         42099    42304   +205     
- Misses       28023    28152   +129     
Files Coverage Δ
...xt/accounts/doctype/journal_entry/journal_entry.py 66.54% <100.00%> (+0.51%) ⬆️
...ounts/doctype/purchase_invoice/purchase_invoice.py 70.30% <100.00%> (+0.12%) ⬆️
...next/accounts/doctype/subscription/subscription.py 77.97% <100.00%> (+0.25%) ⬆️
erpnext/accounts/party.py 81.42% <100.00%> (+0.30%) ⬆️
erpnext/controllers/sales_and_purchase_return.py 91.18% <100.00%> (+0.57%) ⬆️
erpnext/hooks.py 100.00% <100.00%> (ø)
erpnext/manufacturing/doctype/bom/bom.py 73.32% <100.00%> (+0.75%) ⬆️
erpnext/regional/united_arab_emirates/utils.py 38.38% <100.00%> (ø)
erpnext/setup/install.py 23.14% <ø> (-0.07%) ⬇️
erpnext/setup/setup_wizard/setup_wizard.py 75.86% <ø> (ø)
... and 22 more

... and 28 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit f057dc6 into frappe:develop Jan 10, 2024
14 checks passed
deepeshgarg007 added a commit that referenced this pull request Jan 11, 2024
…-39256

fix: Ignore default payment terms template for opening invoices (#39256)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening invoice creation tool due date is always wrong
1 participant