Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react: update to 16.12.0 #1159

Merged
merged 1 commit into from
Jan 30, 2020
Merged

react: update to 16.12.0 #1159

merged 1 commit into from
Jan 30, 2020

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Jan 14, 2020

If you're updating an existing documentation to it's latest version, please ensure that you have:

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date and that the documentation's entry in the array in about_tmpl.coffee matches it's data in self.attribution
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good

Ad license: https://reactjs.org/docs/getting-started.html and https://github.com/reactjs/reactjs.org/blob/master/src/theme.js and facebook/react#13593 mention different licenses. Let's stick with the current one?

j-f1 added a commit that referenced this pull request Jan 30, 2020
@j-f1 j-f1 merged commit 761752d into freeCodeCamp:master Jan 30, 2020
@j-f1
Copy link
Contributor

j-f1 commented Feb 10, 2020

Fixes in 038869a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants