Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update github scraper #2015

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

ClasherKasten
Copy link
Contributor

@ClasherKasten ClasherKasten commented Jul 24, 2023

tweak github scraper to work again after GitHub UI update which gives back JSON data
fixes #2014

Needed to:

  • update the scraper to check if response is valid json after the usual fails
  • updat the parse method to extract the data correctly before processing

tweak github scraper to work again after GitHub UI update which gives back JSON data
@ClasherKasten ClasherKasten requested a review from a team as a code owner July 24, 2023 21:43
@andyholmes
Copy link
Contributor

You can set this to close #2014, if you like.

@ClasherKasten
Copy link
Contributor Author

yeah, you're right... I completely forgot to do so 😅

Copy link
Contributor

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@simon04 simon04 merged commit dd75c13 into freeCodeCamp:main Jul 26, 2023
1 check passed
@ClasherKasten ClasherKasten deleted the fix/github-scraper branch July 26, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github scraper seems broken, since new UI rollout
3 participants