Skip to content
This repository has been archived by the owner on Jan 7, 2024. It is now read-only.

test: regression coverage for #111 (KeyError due to filename), also fix ci on master #112

Merged
merged 2 commits into from
Feb 12, 2020

Conversation

redshiftzero
Copy link
Contributor

@redshiftzero redshiftzero commented Feb 11, 2020

#111 ended up being fixed by #110, here's a regression test (one can verify this claim by checking out 0.0.12, applying this commit, and you should reproduce the KeyError due to filename)

@redshiftzero
Copy link
Contributor Author

Added a commit to fix CI because CI is currently failing on master. This started happening after the virtualenv 20.0 update in the past 24 hours, which will get installed by Pipenv. Since we removed Pipenv from almost everywhere else (and it looks like it's falling into an unmaintained state: pypa/pipenv#4058), I've moved us back to pip-tools as in the other SecureDrop repositories in 1140d40.

@redshiftzero redshiftzero changed the title test: regression coverage for #111 (KeyError due to filename) test: regression coverage for #111 (KeyError due to filename), also fix ci on master Feb 11, 2020
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. Approved.

@kushaldas kushaldas merged commit 89af60b into master Feb 12, 2020
emkll added a commit that referenced this pull request Oct 13, 2020
Pipenv was removed in favor of pip-tools in #112
sssoleileraaa pushed a commit that referenced this pull request Oct 13, 2020
Pipenv was removed in favor of pip-tools in #112
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants