Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipatool: Automate opening PR against supported branches #58

Merged
merged 1 commit into from Aug 18, 2017
Merged

ipatool: Automate opening PR against supported branches #58

merged 1 commit into from Aug 18, 2017

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2017

Add new option -B to pr-push. It allows to specify branch(es) that should also
receive patches from PR. New PR is created against specified branch(es) to
allow proper testing by CI. -B may be used multiple times.

@ghost ghost requested a review from nicki-krizek August 8, 2017 18:52
ipatool Outdated
"Failed to apply patches onto %s/%s. Manual backport is "
"needed. %s" % (ctx.config['remote'], bb, res.stderr)
))
continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cleanup should be performed here.

ipatool Outdated
@@ -115,6 +116,7 @@ browser: firefox
# GitHub configuration
gh-token: "0123456789abcdef0123456789abcdef01234567"
gh-repo: "freeipa/freeipa"
gh-fork-remote: "ghfreeipa"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use "my-github" or something similar as an example. This can be confused as "github freeipa" (as in mirror of upstream pagure), which is not what we want here.

Add new option -B to pr-push. It allows to specify branch(es) that should also
receive patches from PR. New PR is created against specified branch(es) to
allow proper testing by CI. -B may be used multiple times.
@nicki-krizek nicki-krizek merged commit d878021 into freeipa:master Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant