Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Check for unclaimed rewards #1969

Closed
shannonwells opened this issue May 10, 2024 · 0 comments
Closed

[Feature]: Check for unclaimed rewards #1969

shannonwells opened this issue May 10, 2024 · 0 comments
Assignees
@shannonwells
Milestone
Boosting: Non-Eco...

Comments

@shannonwells
Copy link
Collaborator

shannonwells commented May 10, 2024 •
edited
Loading

Need functionality to tell if there are any unclaimed rewards so that it can be determined if an unstake can succeed or whether it's time to claim rewards.

Assumptions:

  • claiming rewards is all or nothing - everything is claimed, or the claim_rewards transaction fails because required conditions are not met.
  • rewards cannot be claimed for eras past the configured history limit (StakingRewardsPastErasMax).

Returns:

BoundedVec<UnclaimedRewardInfo<T: Config>, T::StakingRewardsPastErasMax>
@shannonwells shannonwells self-assigned this May 13, 2024
@shannonwells shannonwells mentioned this issue May 16, 2024
Merged
3 tasks
shannonwells added a commit that referenced this issue May 21, 2024
@shannonwells
Feat/check unclaimed rewards 1969 (#1972)
aeaec44 
# Goal
The goal of this PR is to implement `list_unclaimed_rewards`, and also
one that is lighter weight, `has_unclaimed_rewards`, which returns a
`bool` and which `unstake` extrinsic uses. Unstake now fails if there
are any unclaimed rewards.

Closes #1969 
Closes #1578
shannonwells added a commit that referenced this issue May 22, 2024
@shannonwells
Feat/check unclaimed rewards 1969 (#1972)
b3191c8 
The goal of this PR is to implement `list_unclaimed_rewards`, and also
one that is lighter weight, `has_unclaimed_rewards`, which returns a
`bool` and which `unstake` extrinsic uses. Unstake now fails if there
are any unclaimed rewards.

Closes #1969
Closes #1578
This was referenced Jun 12, 2024
Closed
Closed
shannonwells added a commit that referenced this issue Jun 12, 2024
@shannonwells
Feat/check unclaimed rewards 1969 (#1972)
7b963bc 
The goal of this PR is to implement `list_unclaimed_rewards`, and also
one that is lighter weight, `has_unclaimed_rewards`, which returns a
`bool` and which `unstake` extrinsic uses. Unstake now fails if there
are any unclaimed rewards.

Closes #1969
Closes #1578
shannonwells added a commit that referenced this issue Jun 25, 2024
@shannonwells
Feat/check unclaimed rewards 1969 (#1972)
8c9e13b 
The goal of this PR is to implement `list_unclaimed_rewards`, and also
one that is lighter weight, `has_unclaimed_rewards`, which returns a
`bool` and which `unstake` extrinsic uses. Unstake now fails if there
are any unclaimed rewards.

Closes #1969
Closes #1578
shannonwells added a commit that referenced this issue Jul 18, 2024
@shannonwells
Feat/check unclaimed rewards 1969 (#1972)
7d1494f 
The goal of this PR is to implement `list_unclaimed_rewards`, and also
one that is lighter weight, `has_unclaimed_rewards`, which returns a
`bool` and which `unstake` extrinsic uses. Unstake now fails if there
are any unclaimed rewards.

Closes #1969
Closes #1578
shannonwells added a commit that referenced this issue Jul 23, 2024
@shannonwells
Feat/check unclaimed rewards 1969 (#1972)
863e26a 
The goal of this PR is to implement `list_unclaimed_rewards`, and also
one that is lighter weight, `has_unclaimed_rewards`, which returns a
`bool` and which `unstake` extrinsic uses. Unstake now fails if there
are any unclaimed rewards.

Closes #1969
Closes #1578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shannonwells shannonwells

Labels
None yet
Projects
None yet
Milestone
Boosting: Non-Economic Runtime Code
Development

No branches or pull requests
1 participant
@shannonwells