-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run benchmarks and update weights for pallet_collective once benchmarks are fixed for external pallets #706
Comments
Do we need to wait for a new release from substrate? |
@enddynayn Yes. I added it to the v0.9.32 milestone as that is when I expect it to be available, but I missed the blocked label. |
From what I see in the |
Benchmarking for both pallets appears to be still failing. I am researching what (if anything) we can do about it.
|
I increased the maximum number of tech committee members from 3 to 10 (same as max council members) which fixed the benchmarking. |
As this issue is for the collective pallet, I will not re-enable the collator selection pallet benchmarks. That can be a separate issue if desired. |
The PR was missing a couple of items which should now be fixed in the next PR. |
The following Benchmarks in pallet versions 0.9.29 are failing:
We need to keep an eye out for these fixes, run the benchmarks for the pallets and then use our weights in the relevant next frequency update.
The text was updated successfully, but these errors were encountered: