fix: disconnect additional ApiPromise connection after tests run #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraswatpuneet
approved these changes
Jun 27, 2023
shannonwells
approved these changes
Jun 27, 2023
…romise-disconnect-after-tests-run
JoeCap08055
deleted the
1620-bug-integration-test-suite-missing-apipromise-disconnect-after-tests-run
branch
shannonwells
pushed a commit
that referenced
this pull request
Apr 16, 2024
# Goal The goal of this PR is to make sure all Frequency node connections get closed after integration tests run. Closes #1620 # Checklist - [ ] Chain spec updated - [ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment. - [ ] Design doc(s) updated - [ ] Tests added - [ ] Benchmarks added - [ ] Weights updated Co-authored-by: Wil Wade <wil.wade@unfinished.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to make sure all Frequency node connections get closed after integration tests run.
Closes #1620
Checklist