feat: change user handle #1647

rlaferla · 2023-07-28T17:34:16Z

Goal

The goal of this PR is add the ability to change a user handle.

A user who already has claimed a user handle can now change it using the change_handle() extrinsic.
The change_handle() extrinsic can be paid directly with tokens or with capacity

Changing a user handle, will retire the existing handle and claim a new one. The extrinsic emit HandleRetired and HandleClaimed events.

…m/LibertyDSNP/frequency into 1627-user-handles-handle-swapping

…ks run in CI)

codecov · 2023-07-28T18:23:56Z

Codecov Report

Merging #1647 (25f2102) into main (f6fbf84) will decrease coverage by 0.18%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##             main    #1647      +/-   ##
==========================================
- Coverage   73.53%   73.35%   -0.18%     
==========================================
  Files          49       49              
  Lines        4889     4924      +35     
==========================================
+ Hits         3595     3612      +17     
- Misses       1294     1312      +18

Files Changed	Coverage Δ
...requency-tx-payment/src/capacity_stable_weights.rs	`92.22% <0.00%> (-7.78%)`	⬇️
pallets/handles/src/lib.rs	`55.70% <65.62%> (+0.33%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions · 2023-07-28T19:44:19Z

⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion...

github-actions · 2023-07-28T20:18:35Z

✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit 51a0161.

pallets/handles/src/lib.rs

shannonwells

I think this needs a little extra testing

pallets/handles/src/tests/handle_change_tests.rs

pallets/handles/src/lib.rs

pallets/handles/src/tests/handle_change_tests.rs

wilwade

Just one note to update the stable weights with the benchmark generated one. Otherwise looks good to me from a 👀 check.

pallets/frequency-tx-payment/src/capacity_stable_weights.rs

mattheworris

One minor comment typo, not necessary to fix.
Looks good. 🚢 it!

pallets/handles/src/lib.rs

Co-authored-by: Matthew Orris <1466844+mattheworris@users.noreply.github.com>

shannonwells

Cool beans with awesome sauce

rlaferla added 11 commits July 25, 2023 17:17

feat: Implemented change handle

5fbcfc2

feat: Added new argument for unit test

e17895d

fix: Fixed lint issue

1a4c520

Merge branch 'main' into 1627-user-handles-handle-swapping

4ed30ac

refactor: Now changes to handles happens in a separate extrinsic

6a685aa

feat: Added scaffolding for change handle unit tests

65a69c3

Merge branch 'main' into 1627-user-handles-handle-swapping

4f1c642

fix: revised implementation (wip)

201452c

fix: revised and working benchmark

0bd099b

fix: added check for event in unit test

6959420

feat: Added unhappy path to unit tests

bdd8daf

rlaferla requested a review from wilwade as a code owner July 28, 2023 17:34

rlaferla marked this pull request as draft July 28, 2023 17:34

rlaferla added 5 commits July 28, 2023 13:34

Merge branch 'main' into 1627-user-handles-handle-swapping

87b5ca6

chore: add preliminary weights for change_handle()

acd7228

Merge branch '1627-user-handles-handle-swapping' of https://github.co…

16d875d

…m/LibertyDSNP/frequency into 1627-user-handles-handle-swapping

fix: fixed formatting for unit tests

5ef604a

fix: fixed temporary weight signature (will be replaced when benchmar…

644f1c5

…ks run in CI)

fix: Added change_handle() to Capacity payable extrinsics.

15dd546

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jul 28, 2023

Run benchmarks [run-benchmarks handles]

f1abc83

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jul 28, 2023

Update weights for PR #1647

51a0161

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jul 28, 2023

rlaferla marked this pull request as ready for review July 28, 2023 21:11

rlaferla requested a review from a team July 28, 2023 21:11

shannonwells reviewed Jul 28, 2023

View reviewed changes

pallets/handles/src/lib.rs Show resolved Hide resolved

shannonwells reviewed Jul 28, 2023

View reviewed changes

pallets/handles/src/tests/handle_change_tests.rs Show resolved Hide resolved

pallets/handles/src/lib.rs Outdated Show resolved Hide resolved

pallets/handles/src/tests/handle_change_tests.rs Show resolved Hide resolved

wilwade reviewed Jul 31, 2023

View reviewed changes

pallets/frequency-tx-payment/src/capacity_stable_weights.rs Outdated Show resolved Hide resolved

refactor: consolidated validation of handle length

ae69257

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jul 31, 2023

rlaferla added 6 commits July 31, 2023 10:38

fix: Added check for HandleRetired event.

1f0e94a

fix: Fixed formatting

a10510b

fix: Fix for capacity stable weights

00a0cca

fix: Added unit test to validate max handle length

a5efaab

fix: Improved unit test for max byte length user handle

08ebd49

refactor: Refactored and improved handle byte length unit tests

71aeaa4

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jul 31, 2023

rlaferla requested review from wilwade and shannonwells July 31, 2023 18:04

mattheworris approved these changes Aug 1, 2023

View reviewed changes

pallets/handles/src/lib.rs Outdated Show resolved Hide resolved

Update pallets/handles/src/lib.rs

b8d04f1

Co-authored-by: Matthew Orris <1466844+mattheworris@users.noreply.github.com>

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 1, 2023

rlaferla enabled auto-merge (squash) August 1, 2023 15:08

shannonwells approved these changes Aug 1, 2023

View reviewed changes

Merge branch 'main' into 1627-user-handles-handle-swapping

a0d9159

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Aug 1, 2023

fix: Increment spec_version

25f2102

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 1, 2023

rlaferla merged commit 1a10f62 into main Aug 1, 2023
30 checks passed

rlaferla deleted the 1627-user-handles-handle-swapping branch August 1, 2023 22:19

wilwade added the change/major Major Changes in this PR label Aug 2, 2023

shannonwells pushed a commit that referenced this pull request Apr 16, 2024

feat: change user handle (#1647)

ace3381

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: change user handle #1647

feat: change user handle #1647

rlaferla commented Jul 28, 2023 •

edited

Loading

codecov bot commented Jul 28, 2023 •

edited

Loading

github-actions bot commented Jul 28, 2023

github-actions bot commented Jul 28, 2023

shannonwells left a comment

wilwade left a comment

mattheworris left a comment

shannonwells left a comment

feat: change user handle #1647

feat: change user handle #1647

Conversation

rlaferla commented Jul 28, 2023 • edited Loading

Goal

codecov bot commented Jul 28, 2023 • edited Loading

Codecov Report

github-actions bot commented Jul 28, 2023

github-actions bot commented Jul 28, 2023

shannonwells left a comment

Choose a reason for hiding this comment

wilwade left a comment

Choose a reason for hiding this comment

mattheworris left a comment

Choose a reason for hiding this comment

shannonwells left a comment

Choose a reason for hiding this comment

rlaferla commented Jul 28, 2023 •

edited

Loading

codecov bot commented Jul 28, 2023 •

edited

Loading