[stateful storage] add a new extrinsic for PaginatedUpsertSignaturePa… #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yloadV2 and PaginatedDeleteSignaturePayloadV2
aramikm
requested review from
shannonwells,
rlaferla,
mattheworris,
saraswatpuneet and
JoeCap08055
Codecov Report
@@ Coverage Diff @@
## main #1651 +/- ##
==========================================
+ Coverage 71.94% 73.53% +1.58%
==========================================
Files 49 49
Lines 4926 4889 -37
==========================================
+ Hits 3544 3595 +51
+ Misses 1382 1294 -88
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
github-actions
bot
added
the
metadata-changed
JoeCap08055
approved these changes
Aug 1, 2023
shannonwells
pushed a commit
that referenced
this pull request
Apr 16, 2024
#1651) # Goal The goal of this PR is to allow generating signatures for paginated storages without having `msa_id` in the payload. Closes #1642 # Discussion - for backwards compatibility reasons instead of just removing the msa_id from the payload I created a v2 for the payload and extrinsic - benchmarks and stables weights are not changed at all so it's using the old extrinsic one # Checklist - [x] Chain spec updated - [x] Unit and Integration Tests added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to allow generating signatures for paginated storages without having
msa_idin the payload.Closes #1642
Discussion
Checklist