Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular updates #1685

Merged
merged 17 commits into from
Sep 27, 2023
Merged

Regular updates #1685

merged 17 commits into from
Sep 27, 2023

Conversation

wilwade
Copy link
Collaborator

@wilwade wilwade commented Sep 25, 2023

Goal

The goal of this PR is to fix various dependabot issues as well as other various updates

Discussion

Copy link
Collaborator

@demisx demisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #1685 (4930354) into main (1fda856) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1685   +/-   ##
=======================================
  Coverage   83.07%   83.07%           
=======================================
  Files          47       47           
  Lines        4485     4485           
=======================================
  Hits         3726     3726           
  Misses        759      759           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -10,7 +10,7 @@
],
"loader": "ts-node/esm",
"spec": [
"./{,!(node_modules|load-tests)/**}/{createMsa,addIPFSMessage,staking,transactions}.test.ts"
"./{,!(node_modules|load-tests)/**}/{createMsa,addIPFSMessage,staking,transactions,handles}.test.ts"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added support for the handles test in the testnet test runner


export async function ipfsCid(content: string, path: string) {
// create a Helia node
const helia = await createHelia({ start: false });
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually need to start the server to get the CID from it

@@ -0,0 +1,21 @@
import { unixfs } from '@helia/unixfs';
import { createHelia } from 'helia';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js-ipfs is deprecated. Helia is now the standard.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you figure out helia? would be great if we can get a refresher

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just used https://github.com/ipfs/helia/wiki/Migrating-from-js-IPFS and the other Helia examples.

@@ -2,12 +2,13 @@
"name": "frequency-integration-tests",
"version": "1.0.0",
"description": "Integration tests for the Frequency project",
"type": "module",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests are now esmodules

@@ -4,7 +4,7 @@
"compilerOptions": {
"allowSyntheticDefaultImports": true,
"esModuleInterop": true,
"module": "CommonJS",
"module": "esnext",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Collaborator

@JoeCap08055 JoeCap08055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Helia is something content publishing service would like to learn later

@wilwade wilwade enabled auto-merge (squash) September 27, 2023 14:30
@wilwade wilwade merged commit d6f7d25 into main Sep 27, 2023
30 checks passed
@wilwade wilwade deleted the chore/regular-updates branch September 27, 2023 14:32
shannonwells pushed a commit that referenced this pull request Apr 16, 2024
# Goal
The goal of this PR is to fix various dependabot issues as well as other
various updates

# Discussion
- Update api-augment packages
- Update integration tests packages
- Update integration tests to use Helia instead of js-ipfs
- Cargo updates
- Closes #1503
- Closes: #1663

---------

Co-authored-by: Matthew Orris <1466844+mattheworris@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dos] Possibility of dos in a transitive crate called webpki Integration tests on Rococo handles/
5 participants