-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regular updates #1685
Regular updates #1685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
Codecov Report
@@ Coverage Diff @@
## main #1685 +/- ##
=======================================
Coverage 83.07% 83.07%
=======================================
Files 47 47
Lines 4485 4485
=======================================
Hits 3726 3726
Misses 759 759 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
55742ed
to
e8ec052
Compare
d93135b
to
a5e8a59
Compare
@@ -10,7 +10,7 @@ | |||
], | |||
"loader": "ts-node/esm", | |||
"spec": [ | |||
"./{,!(node_modules|load-tests)/**}/{createMsa,addIPFSMessage,staking,transactions}.test.ts" | |||
"./{,!(node_modules|load-tests)/**}/{createMsa,addIPFSMessage,staking,transactions,handles}.test.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added support for the handles test in the testnet test runner
|
||
export async function ipfsCid(content: string, path: string) { | ||
// create a Helia node | ||
const helia = await createHelia({ start: false }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't actually need to start the server to get the CID from it
@@ -0,0 +1,21 @@ | |||
import { unixfs } from '@helia/unixfs'; | |||
import { createHelia } from 'helia'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
js-ipfs is deprecated. Helia is now the standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you figure out helia? would be great if we can get a refresher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just used https://github.com/ipfs/helia/wiki/Migrating-from-js-IPFS and the other Helia examples.
@@ -2,12 +2,13 @@ | |||
"name": "frequency-integration-tests", | |||
"version": "1.0.0", | |||
"description": "Integration tests for the Frequency project", | |||
"type": "module", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integration tests are now esmodules
@@ -4,7 +4,7 @@ | |||
"compilerOptions": { | |||
"allowSyntheticDefaultImports": true, | |||
"esModuleInterop": true, | |||
"module": "CommonJS", | |||
"module": "esnext", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Helia is something content publishing service would like to learn later
# Goal The goal of this PR is to fix various dependabot issues as well as other various updates # Discussion - Update api-augment packages - Update integration tests packages - Update integration tests to use Helia instead of js-ipfs - Cargo updates - Closes #1503 - Closes: #1663 --------- Co-authored-by: Matthew Orris <1466844+mattheworris@users.noreply.github.com>
Goal
The goal of this PR is to fix various dependabot issues as well as other various updates
Discussion
webpki
#1663